Skip to content

Fixes #9014 #9115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fixes #9014 #9115

wants to merge 6 commits into from

Conversation

aryan1165
Copy link
Contributor

@aryan1165 aryan1165 commented Sep 28, 2023 •
edited
Loading

Describe your change:

Fixes #9014
Added nums.copy() instead of nums for permute_recursive().

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Sep 28, 2023
@aryan1165 aryan1165 mentioned this pull request Sep 28, 2023
Closed
@aryan1165
Revert "Fixes #9014"
798a3c3 
This reverts commit ed58632.

Reverting this commit as it is not merged
@aryan1165
Revert "Revert "Fixes #9014""
700c543 
This reverts commit 798a3c3.
@aryan1165 aryan1165 closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue with permute_recursive
1 participant
@aryan1165